I don't know how the project overall likes to handle things like this. I'm guessing that true devs would
prefer to NOT litter code with #if #endif statements, but that's for you guys to decide.

There is no general policy against #if pre-processor statements in the code. Sure, we try to avoid them if possible. But in this particular case where its necessary to ensure compatibility with different libraries, it is of course fine. This is used also in other modules.

Lets wait a bit if Daniel has some comments on the referenced pull request. Otherwise I can also merge it, for me it looks fine.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.