Hello Henning,

After the push I realized that I forgot to update the author. My bad.

I wanted to revert the commit, but I didn't know if we have a preferred way of doing it.

So, is there a guideline for reverting a commit? I will revert it and re-commit with proper credentials.

Thanks,

Ovidiu

On Thu, Feb 21, 2019, 02:51 Henning Westerholt <hw@kamailio.org> wrote:

Am Mittwoch, 20. Februar 2019, 21:12:07 CET schrieb root:
> Module: kamailio
> Branch: master
> Commit: 91b2c5da34ba7064f858b13bf0a1d27da74336d4
> URL:
> https://github.com/kamailio/kamailio/commit/91b2c5da34ba7064f858b13bf0a1d27
> da74336d4
>
> Author: root <root@livepbx-nit-syd-kam-01.livepbx.com.au>
> Committer: root <root@livepbx-nit-syd-kam-01.livepbx.com.au>
> Date: 2019-02-21T07:11:25+11:00
>
> siputils: fix debug logging
>
> ---
>
> Modified: src/modules/siputils/contact_ops.c
>
> ---
>
> Diff:
> https://github.com/kamailio/kamailio/commit/91b2c5da34ba7064f858b13bf0a1d27
> da74336d4.diff Patch:
> https://github.com/kamailio/kamailio/commit/91b2c5da34ba7064f858b13bf0a1d27
> da74336d4.patch

Hello,

please add a proper User and e-mail address to your local git configuration:

https://help.github.com/en/articles/setting-your-commit-email-address-in-git
https://help.github.com/en/articles/setting-your-username-in-git

It is necessary to have a proper (human) author for all commits in the public
repository. Please reply to this e-mail that we have it in the archives as
well.

Otherwise I think we should revert this commit (could be of course applied
again).

Best regards,

Henning

--
Henning Westerholt - https://skalatan.de/blog/
Kamailio services - https://skalatan.de/services
Kamailio security assessment - https://skalatan.de/de/assessment

_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev