Re: [sr-dev] sdpops: new function sdp_get_ip_c

Hello, I think that it would be better to have a generic function in the configuration file like: sdp_get_attr(line, attr, result) Where line can be: m, c, o, etc ... I'm agree with that

The attr can be: ip, port, ... For the moment, this function will be a wrapper around the two functions, so it supports: - sdp_get_attr("m", "port", result) - sdp_get_attr("c", "ip", result)

dozens of the configuration file functions if we go for one per attribute. What do you think? Also, at some point I should add a PV class for sdp access (if nobody will do it meanwhile). Cheers, Daniel On 9/11/12 11:51 AM, Vicente Hernando wrote: Hello Konstantin, attached patch provides a function that gets ports and stores them in an AVP variable. However, there are other approaches to create these functions: - A function to return each parameter (sdp_get_ip_c, sdp_get_port, etc) - An only function sdp_get_address which return two AVP variables, IP and port for each stream. - A generic function sdp_get_stream_info which receives an enum indicating what variable do you like and return it. - Two functions: sdp_get_stream_count, sdp_get_stream_info(stream_num, enum_variable, pseudo_variable) First would get total number of streams (asuming one session in offer/answer way), and second function would return that variable value for a stream. Daniel, as sdpops maintainer which approach would you rather? Kind regards, Vicente. On 09/07/2012 04:37 PM, Konstantin M. wrote: Hi Vicente, It's my personal but I think would be good to also have another one function to extract a port of media stream. Because of no 'sdp_get_ip_c' and no something like 'sdp_get_port_c' - I have to parse sdb body by python script just to fetch IP/PORT of media stream... 2012/9/7 Vicente Hernando <vhernando(a)systemonenoc.com> _______________________________________________ sr-dev mailing listsr-dev@lists.sip-router.orghttp://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev _______________________________________________ sr-dev mailing listsr-dev@lists.sip-router.orghttp://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev -- Daniel-Constantin Mierla - http://www.asipto.comhttp://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio Advanced Training, Berlin, Nov 5-8, 2012 - http://asipto.com/u/kat Kamailio Advanced Training, Miami, USA, Nov 12-14, 2012 - http://asipto.com/u/katu _______________________________________________ sr-dev mailing list sr-dev(a)lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev