[sr-dev] [tracker] Task opened: Sanity checks lets invalid RURI through

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Andrew Pogrebennyk (marduk) Attached to Project - sip-router Summary - Sanity checks lets invalid RURI through Task Type - Bug Report Category - Module Status - Unconfirmed Assigned To - Operating System - Linux Severity - Low Priority - Normal Reported Version - 3.3 Due in Version - Undecided Due Date - Undecided Details - We are using message and URI checks in sanity module: if(!sanity_check("1511", "7")) { xlog("L_WARN", "Malformed SIP message deteted - R=$ru ID=$ci\n"); sl_send_reply("483","Malformed SIP Message"); exit; } We've found that if the request comes in with broken RURI, the result of sanity check is still 1 which means passed: Jan 8 12:31:26 sp2 /usr/sbin/kamailio[1121]: INFO: <script>: New request - M=INVITE R=sip:%3A03581313184:03581313184@192.168.51.16 F=sip:43991001@192.168.51.16 T=sip:%3A03581313184:03581313184@192.168.51.16 IP=192.168.51.1:39851 (127.0.0.1:5060) ID=vGo5pfQRI9hwaVUAhcc4gZcXgl5jIHDr Jan 8 12:31:26 sp2 /usr/sbin/kamailio[1121]: DEBUG: maxfwd [mf_funcs.c:85]: value = 69 Jan 8 12:31:26 sp2 /usr/sbin/kamailio[1121]: DEBUG: sanity [mod_sanity.c:255]: sanity checks result: 1 Jan 8 12:31:26 sp2 /usr/sbin/kamailio[1121]: DEBUG: rr [loose.c:111]: No Route headers found Jan 8 12:31:26 sp2 /usr/sbin/kamailio[1121]: DEBUG: rr [loose.c:835]: There is no Route HF Jan 8 12:31:26 sp2 /usr/sbin/kamailio[1121]: DEBUG: <core> [strcommon.c:224]: unescaped string is <:03581313184> Jan 8 12:31:26 sp2 /usr/sbin/kamailio[1121]: DEBUG: <core> [parser/parse_uri.c:1259]: parse_uri: bad char ':' in state 0 parsed: <sip:> (4) / <sip::03581313184:03581313184@192.168.51.16> (42) Jan 8 12:31:26 sp2 /usr/sbin/kamailio[1121]: DEBUG: <core> [parser/parse_uri.c:1327]: ERROR: parse_sip_msg_uri: bad uri <sip::03581313184:03581313184@192.168.51.16> Jan 8 12:31:26 sp2 /usr/sbin/kamailio[1121]: ERROR: pv [pv_core.c:300]: failed to parse the R-URI Jan 7 15:39:24 sp2 /usr/sbin/kamailio[13257]: ERROR: <core> [lvalue.c:347]: non existing right pvar Jan 7 15:39:24 sp2 /usr/sbin/kamailio[13257]: ERROR: <core> [action.c:777]: ERROR: do_action: bad uri <sip::03581313184:03581313184@192.168.51.16>, dropping packet Jan 7 15:39:24 sp2 /usr/sbin/kamailio[13257]: ERROR: <core> [action.c:1525]: run action error at: :0 ^^ Additionally the filename and line number in the above error message "run action error at .." is missing. Please check. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=264 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.