https://github.com/kamailio/kamailio/blob/ecc2cc69b08e797ca954af233c229ed44475ce33/src/modules/nathelper/nathelper.c#L1699

First of all, using 'a=rtcp' in replace_sdp_ip() violates a principle of SoC (separation of concerns).
Comparsion with 'a=rtcp' should be made at ki_fix_nated_sdp_ip(). Issue #2768 is perfect, but merge #2769 is "some word".

The original #2768 (71441c0) contain bug with out-of-bound.

Later on (521485c) it was brought to new problem. Using linelen comparsion with memcmp() avoids appearing an error while "o=xxx" or "c=ccc" (while linelen is less then 6 chars).

I tried to fix it.

It looks like a duct tape. I get the impression, there's no a code review at the project. I think, that you have look even my fix very superficially.

You are very quick-tempered, for any criticism you are answer: "go away", "offend" etc.

P.S. Unfortunately, I didn't have any free time and was unable to review code #2768 prior to commit.
P.P.S. Can you provide a stoplist of words, that inappropriate? for using.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.