[sr-dev] Re: [kamailio/kamailio] dialplan: improve performance by reusing PCRE structure (PR #4289)

@linuxmaniac commented on this pull request.

@@ -427,6 +427,14 @@ int rule_translate(sip_msg_t *msg, str *instr, dpl_node_t *rule,

return 0; }

+ if(pcre_md == NULL) { + pcre_md = pcre2_match_data_create(MAX_REPLACE_WITH, NULL);

if we don't set the second parameter we are no longer using ``pcre2_compile_context *dpl_ctx`` that we were using implicitly when using ``pcre2_match_data_create_from_pattern`` so we no longer using ``pcre2_malloc/pcre2_free`` are you aware of that change?

Since you are using ``static`` now I'm assuming we don't really need to use shm here. But, nevertheless, we will end up using plain ``malloc/free`` and not ``pkg_malloc/pkg_free``