[sr-dev] [kamailio/kamailio] presence: error "transaction already started" when updating watcher records on db-only mode (#960)

We do have this ``presence`` module parameters: ``` modparam("presence", "subs_db_mode", 3) modparam("presence", "publ_cache", 0) modparam("presence", "db_table_lock_type", 0) modparam("presence", "notifier_processes", 3) modparam("presence", "send_fast_notify", 0) ``` And we are getting this errors several times per second ``` proxy[9056]: ERROR: db_mysql [km_dbase.c:602]: db_mysql_start_transaction(): transaction already started proxy[9056]: ERROR: presence [notify.c:1365]: publ_notify_notifier(): in start_transaction proxy[9056]: ERROR: presence [presentity.c:1132]: update_presentity(): updating watcher records proxy[9056]: ERROR: presence [publish.c:462]: handle_publish(): when updating presentity ``` This logs are from kamailio 4.4.4 but I think the problem is in master too. I do see that publ_notify_notifier() has a call to start_transaction() https://github.com/kamailio/kamailio/blob/master/src/modules/presence/notif… but we are already inside a transaction either at https://github.com/kamailio/kamailio/blob/master/src/modules/presence/prese… or https://github.com/kamailio/kamailio/blob/master/src/modules/presence/prese… -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/960