6 Jul
2022
6 Jul
'22
2:23 p.m.
Hi Folks,
I chose to do this on the Kamailio side as I'm less sure about the impacts to other
applications that may use libstirshaken, whereas I understand the full use-case of the
kamailio module. I've watched a few other PRs and bug reports to libstirshaken sit
untouched for many months at a time so also less optimistic about that leading to a quick
resolution.
The PR I already submitted (a one-line change) has already been accepted and merged, fyi.
Yes, libstirshaken library wasn't maintained very actively, however your last PR could
have been merged much more smoothly, so maybe you could try with the complete patch?
To solve versioning, we would add versioning to libstirshaken AC_INIT macro in
configure.ac, then we would check version with configure and set a define to be used in
Kamailio module, if libstirshaken version is old then module would use your new functions,
otherwise libstirshaken can be used.
Yet another solution is to use a fork (e.g. this my forked version
https://github.com/dataandsignal/libstirshaken) so we can merge this and other commits
quicker. Effect would be the same as patching Kamailio module, new Kamailio version would
rely on a fork with new feature, old version would not have the feature.
So:
1. You can try to merge versionng commit, and chain changes to signalwire/libstirshaken
2. Use my fork, and I can help with merging this quickly
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3175#issuecomment-1176103835
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3175/c1176103835(a)github.com>