15 Sep
2023
15 Sep
'23
10:46 a.m.
@miconda I think the fix is not really good since is
not taking care of memory and if the previous value is equal. Created a new PR with a
possible solution. @schiramchetty please take a look and test it
Hi @linuxmaniac, Thanks for your feedback.
We are not allocating any new memory for the requested PR and we are just updating the
existing variable value using
SCA_STR_COPY(&saved_sub->rr, &update_sub->rr);
Also we have tested with this PR and we are not finding any memory-related issues and all
the scenarios are working as expected. Please let us know do we need to create a new PR as
proposed by @miconda. or do you need any clarifications on this PR. Please suggest.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3569#issuecomment-1720828693
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3569/c1720828693(a)github.com>