@theraphim commented on this pull request.


In src/core/socket_info.c:

> @@ -1184,6 +1189,16 @@ static int build_iface_list(void)
 		nll = 0;
 		p = buf;
 		while(1) {
+			// This (and the loop above in get_flags) is
+			// broken in more than one aspect. For example,
+			// if a receive is shorter than nlmsghdr,
+			// nlp->nlmsg_type will point at garbage.
+			// Proper fix for this (and static buffer sizing
+			// problem) would be to use libnl.

Removed.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.