@fgaisnon: release process for v5.7.3 started earlier today and I didn't merge before because @henningw's comment is rather confusing for me, requesting also more time for others to review the PR.

As I understood from the description of the PR, this should be a fix for a regression introduced by commit 091dc9a, which was done by @henningw. So handling early dialog BYEs was fine before that commit, but his comment is about validity of sending BYE instead of CANCEL in an early dialog.

BYE during early dialog has a different purpose than CANCEL, but that is not the real matter here, handling early dialog BYEs was (supposed to be) supported for long time by topos. Considering that I thought that @henningw's comment is unrelated to the commit of the PR and since it was opened yesterday I haven't had the time to review again the previous related commit and what this PR brings to it, combined with the fact that I had no easy option to test early dialog BYEs, I skipped it for 5.7.3.

Probably it will be merged soon if all ok with it and then backported, afterwards you can use nightly builds of 5.7 series if you rely on Debian packages, till 5.7.4 is out.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <kamailio/kamailio/pull/3644/c1816311617@github.com>