Re: [sr-dev] [kamailio/kamailio] Is t_flush_flags() really needed? (#1490)

Looked in the code and the flags are resync'ed on t_relay() (or the similar relay functions), that happens because of: * https://github.com/kamailio/kamailio/blob/master/src/modules/tm/t_lookup.c#… And t_newtran() is executed inside t_relay_to(): * https://github.com/kamailio/kamailio/blob/master/src/modules/tm/t_funcs.c#L… The behaviour is coming via SER project, based on the comments there. I am going to add the same for xflags. On the other hand, the t_flush_flags() might still be useful for the case when the transaction is created, but not forwarded (e.g., local handling or, even I haven't checked the code, could be the case of suspending the transaction), so I am going to keep the functions, but document that they are not needed if the transaction is forwarded with t_relay() or similar functions. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1490#issuecomment-380444664