Hello,

thanks for the patch -- when the module is destroyed, practically is the shut down of kamailio, when the entire memory used is freed (pkg and shm) as well as the one from the system by the system manager. Anyhow, for a clean shut down, is good to have it.

One thing is not clear, where the function redisc_free_reply(str *name) is used? The patch seems just to define it.

Cheers,
Daniel

Ops, sorry, I send a wrong patch, that one creates an API for ndb_redis module.

The patch attached now is the correct one.

Regards,
Vicente.



On 05/02/2012 09:33 PM, Vicente Hernando wrote:

Hello,

looking at ndb_redis module source code I see replies are not freed when module is destroyed.

Also a reply is only freed when another one with same name is performed. This could cause problems if an user would ask for
a lot of different named replies.

IMHO freeing reply list when module is destroyed and creating a new redisc_free_reply function would solve this.


I attach a patch that compiles but not tested to show the idea.

If you agree I can perform the task, I suppose redisc_free_reply function should also be exported in cmd_export_t module structure.


This solution would be compatible with old ndb redis module configuration.



Regards,
Vicente.

_______________________________________________
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

_______________________________________________
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda