Pre-Submission Checklist

Commit message has the format required by CONTRIBUTING guide
Commits are split per component (core, individual modules, libs, utils, ...)
Each component has a single commit (if not, squash them into one commit)
No commits to README files for modules (changes must be done to docbook files
in doc/ subfolder, the README file is autogenerated)

Type Of Change

Small bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would change existing functionality)

Checklist:

PR should be backported to stable branches
Tested changes locally
Related to issue #XXXX (replace XXXX with an open issue number)

Description

Currently, when making an AAR, transaction is suspended and then continued. This is because one may want to block call upon AAR failure.

In our use case, we don't want to block any calls, regardless of AAR return code. This makes suspend/continue of the transaction an overhead. Moreover, if the PCRF is slow, transaction blocks untill PCRF responds.

Add a module parameter to control if one wants to suspend or not the tm transaction (default is the current behavior). Local basic tests work ok, more testing will follow.

You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/3581

Commit Summary

7e6c01d ims_qos: Add suspend_transaction parameter

File Changes

(3 files)

M src/modules/ims_qos/doc/ims_qos_admin.xml (19)
M src/modules/ims_qos/ims_qos_mod.c (49)
M src/modules/ims_qos/rx_aar.c (57)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.