Re: [sr-dev] [kamailio/kamailio] tls_wolfssl: new module TLS stack based on wolfSSL (PR #3144)

Hello, thanks for the pull request. It was merged really fast. I would appreciate some comments on how to address the code duplication from the existing tls module. Just checked briefly, but several header files are completely identical, in some cases just a few differences (tls_rpc.h, tls_ct_q.h etc..) . Also some implementation is idential (tls_verify.c) The approach from tlsa module to just include the headers if they are not modified seems better to me than to just copy them completely. This is one of the more complicated modules, and now we are having three tls modules. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3144#issuecomment-1157319440 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3144/c1157319440(a)github.com>