Pre-Submission Checklist

• Commit message has the format required by CONTRIBUTING guide
• Commits are split per component (core, individual modules, libs, utils, ...)
• Each component has a single commit (if not, squash them into one commit)
• No commits to README files for modules (changes must be done to docbook files
  in doc/ subfolder, the README file is autogenerated)

Type Of Change

• Small bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds new functionality)
• Breaking change (fix or feature that would change existing functionality)

Checklist:

• PR should be backported to stable branches
• Tested changes locally
• Related to issue #1783

Description

The result of this check is always false (or I think so because I always obtain 0!=8) and the function dlg_new_dialog() is never executed.

The function dlg_new_dialog() must be executed to save the new dialog. In other case the cnxcc module (I don know if there are more modules affected) doesn't work.

Can anyone review if this check is important, please?

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1791

Commit Summary

• dialog: The result of this check is always false and the function dlg_new_dialog() is never executed

File Changes

• M src/modules/dialog/dlg_handlers.c (2)

Patch Links:

• https://github.com/kamailio/kamailio/pull/1791.patch
• https://github.com/kamailio/kamailio/pull/1791.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.