27 Jul
2011
27 Jul
'11
11:29 a.m.
On Wednesday 27 July 2011, Peter Dunkley wrote:
Branch: pd/crocodile Commit: 6033da2e644ccdca7fa57bee03f82cb03c36e45e [..]
Hi Peter,
nice extensions, thank you for this. :-) Your work is still in a dedicated branch, but please allow me a few comments:
* please increase the version number in the module and scheme if you do bigger/ incompatible changes to the scheme
* you change the mysql SQL to a postgres style (e.g. INTEGER instead of INT(n), SERIAL instead of AUTO_INCREMENT, remove the engine type etc..), I guess this was done by mistake?
Best regards,
Henning