Re: [sr-dev] [kamailio/kamailio] dialog: adding dlg.dump (#2272)

Thanks, I am fine to merge it with one more remark. Thinking a bit more about the rpc command name, I would suggest to change it to `dumpfile` or something else to suggest is writing to a file. Actually I would like to have something different that `dump` because other modules use this name to write back to rpc response. We have now a mixture between `list` and `dump` that write back to rpc response, adding a new `dump` with a different type of behaviour will make it incosistent. For example, if we add a similar command to usrloc for writing to a file, the `dump` command is already there. Let's add a name that can be (re-)used to other modules in the future, so we have some consistency from this perspective. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2272#issuecomment-610214219