Pre-Submission Checklist

Commit message has the format required by CONTRIBUTING guide
Commits are split per component (core, individual modules, libs, utils, ...)
Each component has a single commit (if not, squash them into one commit)
No commits to README files for modules (changes must be done to docbook files
in doc/ subfolder, the README file is autogenerated)

Type Of Change

Small bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would change existing functionality)

Checklist:

PR should be backported to stable branches
Tested changes locally
Related to issue #4019

Description

I assume that the crash #4019 happens, because of an issue in libcurl, namely in the event_cb function (in this line) kamailio removes the pointer to the cell object (which was attached to this g->multi curl descriptor earlier), and the cell object memory is released at this line. However, the crash happens when event_cb is called when curl_multi_remove_handle is called at this line.
In this fix cell object is retrieved from the corresponding CURL descriptor and then it's compared with the cell object passed to this callback.
With this change when this issue happens the cell object, which is retrieved from the corresponding CURL descriptor, is NULL pointer, because it was removed earlier in this line, so the crash should not appear.
However it might be fixed in other way, namely we may not to pass cell to the event_cb callback and always retrieve it from CURL descriptor. I would appreciate if developers comment that.

You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/4020

Commit Summary

6953d6a http_async_client: fixed crash on curl callback

File Changes

(1 file)

M src/modules/http_async_client/http_multi.c (18)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.