Pre-Submission Checklist

[x ] Commit message has the format required by CONTRIBUTING guide
[x ] Commits are split per component (core, individual modules, libs, utils, ...)
[x ] Each component has a single commit (if not, squash them into one commit)
[x ] No commits to README files for modules (changes must be done to docbook files
in doc/ subfolder, the README file is autogenerated)

Type Of Change

Small bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
[x ] Breaking change (fix or feature that would change existing functionality)

Checklist:

PR should be backported to stable branches
[x ] Tested changes locally -- tested at 5.1.6
Related to issue #XXXX (replace XXXX with an open issue number)

Description

Problem:
Forwarding of 200 OK while sent 488 waits for ACK, destroys the UAS send buffer
Scenario:
During suspension of 200 OK by ims_qos module function Rx_AAR() at terminating PCSCF,
The PCRF sends an AA Answer with result code DIAMETER_TOO_BUSY (3004), which triggers
the PCSCF to send a 488 ‘Sorry no QoS available’ to the originating side (ims_dialog
module function dlg_terminate()).
Afterwards neither the 200 OK nor the ACK(488) is processed correctly by the PCSCF.
Solution:
The UAS send buffer should not be overwritten during processing of 200 OK,
because non-2xx is needed to associate the ACK message in a correct way.
200 OK must be forwarded statelessly.
Side-Effect (potentially breaks existing function):
Some callbacks cannot be called for the 200 OK, to avoid messing the stored 488.

You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/2590

Commit Summary

tm: 200 OK not processed correctly by Proxy after final non-2xx

File Changes

M src/modules/tm/t_reply.c (72)

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.