@stefan-mititelu-idt commented on this pull request.


In src/modules/rtpengine/rtpengine.c:

> @@ -3549,6 +3606,10 @@ static int rtpp_test(struct rtpp_node *node, int isdisabled, int force)
 		return 1;
 	}
 	if(force == 0) {
+		/* If ping_interval is set, the timer will ping and test
+		the rtps. No need to do something during routing */
+		if(rtpengine_ping_interval > 0)
+			return 1;

I think this new if condition needs to be after the existing if(isdisabled==0) condition. Otherwise may interfere with the "found:" label in select_rtpp_node_new() and automatically disable a found node


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <kamailio/kamailio/pull/4016/review/2421106460@github.com>