Pre-Submission Checklist

Commit message has the format required by CONTRIBUTING guide
Commits are split per component (core, individual modules, libs, utils, ...)
Each component has a single commit (if not, squash them into one commit)
No commits to README files for modules (changes must be done to docbook files
in doc/ subfolder, the README file is autogenerated)

Type Of Change

Small bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would change existing functionality)

Checklist:

PR should be backported to stable branches
Tested changes locally
Related to issue #XXXX (replace XXXX with an open issue number)

Description

Siptrace module has two different tracing concepts which do mostly the same thing. It has sip_trace function and it has trace_flag parameter which traces messages in a transaction. This pull request aims to have a single point of trace activation, that is when the user calls sip_trace() function from the script. Moreover, it adds 3 levels of tracing: message, transaction and dialog level tracing. This option is added as a parameter to sip_trace(), therefore the user can now summon sip_trace(duri, correlation_id, "m/t/d") where "m" stands for message, "t" for transaction and "d" for dialog.

The patch has been tested both locally and in our company's test system. Locally I've tested it using a few scenarios generated using sipp: successful call, negative reply(491 answer - hop-by-hop ACK), UAC CANCEL and dual bye scenario generated by Kamailio(dialog timeout). The only issue with current patch is it doesn't trace internally generated BYEs that is because they are only a buffer in Kamailio, not a parsed SIP message, therefore, after a few days of searching for solutions I didn't find any valid one. Parsing a SIP message for tracing didn't seem worth the processing time to me, but of course it can be added in the future.

Looking forward to your opinion or suggestions regarding the current patch.

You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/1912

Commit Summary

siptrace: add basic transaction and dialog level tracing
siptrace: trace negative ACKs
siptrace: check if a request is set to avoid local transaction crash
siptrace: Add code to trace incoming CANCEL transcations
siptrace: Minor code fixes; remove useless error logs
siptrace: store sip_trace destination parameter for the entire dialog
siptrace: remove unused trace flag
siptrace: update README

File Changes

M src/core/parser/msg_parser.h (1)
M src/modules/siptrace/README (562)
M src/modules/siptrace/doc/siptrace_admin.xml (33)
M src/modules/siptrace/siptrace.c (864)
M src/modules/siptrace/siptrace_data.h (14)

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.