[sr-dev] git:master:8a45ac1e: modules/ims_icscf: changed 403 to 500 for HSS error responses

Module: kamailio Branch: master Commit: 8a45ac1e1b609497100427cd0a2e37d9037ae184 URL: https://github.com/kamailio/kamailio/commit/8a45ac1e1b609497100427cd0a2e37d… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2015-11-08T12:59:17+02:00 modules/ims_icscf: changed 403 to 500 for HSS error responses --- Modified: modules/ims_icscf/cxdx_lir.c Modified: modules/ims_icscf/cxdx_uar.c Modified: modules/ims_icscf/sip_messages.h --- Diff: https://github.com/kamailio/kamailio/commit/8a45ac1e1b609497100427cd0a2e37d… Patch: https://github.com/kamailio/kamailio/commit/8a45ac1e1b609497100427cd0a2e37d… --- diff --git a/modules/ims_icscf/cxdx_lir.c b/modules/ims_icscf/cxdx_lir.c index 52c09b9..be18eb7 100644 --- a/modules/ims_icscf/cxdx_lir.c +++ b/modules/ims_icscf/cxdx_lir.c @@ -161,14 +161,14 @@ void async_cdp_lir_callback(int is_timeout, void *param, AAAMessage *lia, long e goto success; default: - cscf_reply_transactional_async(t, t->uas.request, 403, MSG_403_UNKOWN_EXPERIMENTAL_RC); + cscf_reply_transactional_async(t, t->uas.request, 500, MSG_500_UNKOWN_EXPERIMENTAL_RC); result = CSCF_RETURN_BREAK; goto done; } break; case AAA_UNABLE_TO_COMPLY: - cscf_reply_transactional_async(t, t->uas.request, 403, MSG_403_UNABLE_TO_COMPLY); + cscf_reply_transactional_async(t, t->uas.request, 500, MSG_500_UNABLE_TO_COMPLY); result = CSCF_RETURN_BREAK; goto done; diff --git a/modules/ims_icscf/cxdx_uar.c b/modules/ims_icscf/cxdx_uar.c index e615c0f..c798f8f 100644 --- a/modules/ims_icscf/cxdx_uar.c +++ b/modules/ims_icscf/cxdx_uar.c @@ -175,8 +175,8 @@ void async_cdp_uar_callback(int is_timeout, void *param, AAAMessage *uaa, long e goto success; default: - LM_ERR("MSG_403_UNKOWN_EXPERIMENTAL_RC returning 403\n"); - cscf_reply_transactional_async(t, t->uas.request, 403, MSG_403_UNKOWN_EXPERIMENTAL_RC); + LM_ERR("MSG_403_UNKOWN_EXPERIMENTAL_RC returning 500\n"); + cscf_reply_transactional_async(t, t->uas.request, 500, MSG_500_UNKOWN_EXPERIMENTAL_RC); result = CSCF_RETURN_FALSE; goto done; } @@ -189,7 +189,7 @@ void async_cdp_uar_callback(int is_timeout, void *param, AAAMessage *uaa, long e goto done; case AAA_UNABLE_TO_COMPLY: LM_ERR("AAA_UNABLE_TO_COMPLY returning 403\n"); - cscf_reply_transactional_async(t, t->uas.request, 403, MSG_403_UNABLE_TO_COMPLY); + cscf_reply_transactional_async(t, t->uas.request, 500, MSG_500_UNABLE_TO_COMPLY); result = CSCF_RETURN_FALSE; goto done; diff --git a/modules/ims_icscf/sip_messages.h b/modules/ims_icscf/sip_messages.h index a93afbe..55394ef 100644 --- a/modules/ims_icscf/sip_messages.h +++ b/modules/ims_icscf/sip_messages.h @@ -52,8 +52,8 @@ #define MSG_400_MALFORMED_CONTACT "Bad Request - Error parsing Contact parameters" #define MSG_400_NO_VISITED "Bad Request - P-Visited-Network-ID header missing" -#define MSG_403_UNKOWN_EXPERIMENTAL_RC "Forbidden - HSS responded with unknown Experimental Result Code" -#define MSG_403_UNABLE_TO_COMPLY "Forbidden - HSS Unable to comply" +#define MSG_500_UNKOWN_EXPERIMENTAL_RC "Forbidden - HSS responded with unknown Experimental Result Code" +#define MSG_500_UNABLE_TO_COMPLY "Forbidden - HSS Unable to comply" #define MSG_403_UNKOWN_RC "Forbidden - HSS responded with unknown Result Code" #define MSG_403_USER_UNKNOWN "Forbidden - HSS User Unknown" #define MSG_403_IDENTITIES_DONT_MATCH "Forbidden - HSS Identities don't match"