Pre-Submission Checklist

• Commit message has the format required by CONTRIBUTING guide
• Commits are split per component (core, individual modules, libs, utils, ...)
• Each component has a single commit (if not, squash them into one commit)
• No commits to README files for modules (changes must be done to docbook files
  in doc/ subfolder, the README file is autogenerated)

Type Of Change

• Small bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds new functionality)
• Breaking change (fix or feature that would change existing functionality)

Checklist:

• PR should be backported to stable branches
• Tested changes locally
• Related to issue #XXXX (replace XXXX with an open issue number)

Description

This change provides support in ndb_redis for a scenario where the Redis server is part of a cluster and the IP addresses of the nodes are either not known in advance or are subject to change (for example in case the cluster sees new nodes being added).
Before this change ndb_redis supports the cluster option, so that after a MOVED response from a node ndb_redis will perform again the same query but towards the redirection target. The caveat is that ndb_redis must know in advance which IP addresses will be used by the nodes.
AMOVED response is in the form -MOVED 1234 1.2.3.4:6379., indicating the hash for the request and the redirection target IP address and port.
Every node in the cluster must have a modparam entry with name=IP_ADDRESS:PORT;addr=IP_ADDRESS;port=PORT.
With the changes in this PR, ndb_redis doesn't need to have in advance the list of nodes but it can "discover" them at runtime.
There is a caveat to this solution: while defining the nodes in advance allows to define also pass, sock and db, this is currently not supported (and default values are used). If this change will be accepted though, we could add a module parameter to define pass, sock and db for the dynamic nodes.

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1436

Commit Summary

• ndb_redis: dynamic discovery of nodes

File Changes

• M src/modules/ndb_redis/doc/ndb_redis_admin.xml (30)
• M src/modules/ndb_redis/ndb_redis_mod.c (2)
• M src/modules/ndb_redis/redis_client.c (53)

Patch Links:

• https://github.com/kamailio/kamailio/pull/1436.patch
• https://github.com/kamailio/kamailio/pull/1436.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.