I don't feel comfortable about this commit.
If it was a backport, it has to be done with 'git cherry-pick -x'
The it looks like it messes up with the build system we have in the stable branch, adding shared objects in different location than internal libs and modules.
Could you revert the commit in branch 4.2 and explain how all these imported libraries are built, installed and planned to be managed. Maybe there are better solutions or other people have solutions for a way that can be reused by other modules.
I don't like importing external libraries in our source code unless it is a clear reason for it and everyone agrees with it.
Also, remember that 4.2 is stable, pushing radical changes without discussing on sr-dev is strongly not recommended. It can break existing installations that are maintained from git. On git master, you have the freedom to play as you think is better, but not backporting immediately to any stable branch.
Cheers, Daniel
On 10/11/14 14:26, Luis Azedo wrote:
Module: sip-router Branch: 4.2 Commit: 1630ec25958bda98a98864cbef57000dab8f2aeb URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1630ec25...
Author: Luis Azedo luis@2600hz.com Committer: Luis Azedo luis@2600hz.com Date: Mon Nov 10 13:25:30 2014 +0000
kazoo : remove dependencies
modules/kazoo/Makefile | 27 +- modules/kazoo/README | 4 +- modules/kazoo/deps/Makefile | 18 + modules/kazoo/deps/amqp.h | 2352 +++++++++++++++++++++++++++++ modules/kazoo/deps/amqp_api.c | 340 +++++ modules/kazoo/deps/amqp_connection.c | 535 +++++++ modules/kazoo/deps/amqp_consumer.c | 308 ++++ modules/kazoo/deps/amqp_framing.c | 2102 ++++++++++++++++++++++++++ modules/kazoo/deps/amqp_framing.h | 640 ++++++++ modules/kazoo/deps/amqp_hostcheck.c | 201 +++ modules/kazoo/deps/amqp_hostcheck.h | 36 + modules/kazoo/deps/amqp_mem.c | 252 +++ modules/kazoo/deps/amqp_openssl.c | 626 ++++++++ modules/kazoo/deps/amqp_private.h | 363 +++++ modules/kazoo/deps/amqp_socket.c | 1388 +++++++++++++++++ modules/kazoo/deps/amqp_socket.h | 195 +++ modules/kazoo/deps/amqp_ssl_socket.h | 168 ++ modules/kazoo/deps/amqp_table.c | 614 ++++++++ modules/kazoo/deps/amqp_tcp_socket.c | 303 ++++ modules/kazoo/deps/amqp_tcp_socket.h | 73 + modules/kazoo/deps/amqp_timer.c | 140 ++ modules/kazoo/deps/amqp_timer.h | 67 + modules/kazoo/deps/amqp_url.c | 218 +++ modules/kazoo/deps/arraylist.c | 101 ++ modules/kazoo/deps/arraylist.h | 56 + modules/kazoo/deps/bits.h | 28 + modules/kazoo/deps/config.h | 209 +++ modules/kazoo/deps/debug.c | 83 + modules/kazoo/deps/debug.h | 71 + modules/kazoo/deps/json.h | 34 + modules/kazoo/deps/json_c_version.c | 20 + modules/kazoo/deps/json_c_version.h | 22 + modules/kazoo/deps/json_config.h | 4 + modules/kazoo/deps/json_inttypes.h | 28 + modules/kazoo/deps/json_object.c | 855 +++++++++++ modules/kazoo/deps/json_object.h | 612 ++++++++ modules/kazoo/deps/json_object_iterator.c | 168 ++ modules/kazoo/deps/json_object_iterator.h | 239 +++ modules/kazoo/deps/json_object_private.h | 47 + modules/kazoo/deps/json_tokener.c | 890 +++++++++++ modules/kazoo/deps/json_tokener.h | 208 +++ modules/kazoo/deps/json_util.c | 300 ++++ modules/kazoo/deps/json_util.h | 41 + modules/kazoo/deps/libjson.c | 26 + modules/kazoo/deps/linkhash.c | 602 ++++++++ modules/kazoo/deps/linkhash.h | 292 ++++ modules/kazoo/deps/math_compat.h | 38 + modules/kazoo/deps/printbuf.c | 192 +++ modules/kazoo/deps/printbuf.h | 77 + modules/kazoo/deps/random_seed.c | 237 +++ modules/kazoo/deps/random_seed.h | 25 + modules/kazoo/deps/threads.h | 29 + modules/kazoo/doc/kazoo_admin.xml | 12 +- modules/kazoo/kazoo.c | 15 + modules/kazoo/kz_amqp.c | 150 ++- modules/kazoo/kz_amqp.h | 6 + modules/kazoo/kz_pua.c | 3 +- 57 files changed, 16644 insertions(+), 46 deletions(-)
Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=1630...
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev