Pre-Submission Checklist

Commit message has the format required by CONTRIBUTING guide
Commits are split per component (core, individual modules, libs, utils, ...)
Each component has a single commit (if not, squash them into one commit)
No commits to README files for modules (changes must be done to docbook files
in doc/ subfolder, the README file is autogenerated)

Type Of Change

Small bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would change existing functionality)

Checklist:

PR should be backported to stable branches
Tested changes locally
Related to issue #XXXX (replace XXXX with an open issue number)

Description

This PR fixes an issue regarding KEMI framework for onsend_route.

KSR.set_drop() in ksr_onsend_route does not make kamailio dropping the message when using kemi (python3) (probably holds true for other engines too):

This is exactly the example from documentation:

def ksr_onsend_route(self, msg):
  KSR.set_drop()
  exit()

The issue arises because we are not setting ret = 0 when the drop flag is set, but instead check if it's not set to return ret=1 (The case for native that returns 0 but no DROP_R_F was set).

Note:
KEMI Case: ret = 1 always See app_python3/apy_kemi.c
Native case: ret can be 0 for drop, or 1 for success

You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/3718

Commit Summary

488d2e7 core: Fix check to also work for KEMI framework

File Changes

(1 file)

M src/core/onsend.c (13)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.