Re: [sr-dev] [kamailio/kamailio] core: Improve handling of async-signal-unsafe code in signal handler (#2127)

The first patch it is ok, SIG_DEBUG is defined by default. Lately some of the devs put efforts in eliminating compile time macro switches that were not changed for very long time, to make the code easier to follow. Anyhow, I am fine with the first commit, if it is useful. But turning this off by default at compile time is not ok, it is needed for tracking memory leaks in PKG and if someone reports it, likely it has it installed with default compile options. Asking to recompile with new flags is not convenient at all, production systems are typically not configured for building packages. And again, the PKG report should not be printed if the global parameters listed above were not changed. The signal handler of the main process is printing only PKG reports for itself, the main process does not print PKG reports for child processes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2127#issuecomment-646147232