Pre-Submission Checklist

Commit message has the format required by CONTRIBUTING guide
Commits are split per component (core, individual modules, libs, utils, ...)
Each component has a single commit (if not, squash them into one commit)
No commits to README files for modules (changes must be done to docbook files
in doc/ subfolder, the README file is autogenerated)

Type Of Change

Small bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would change existing functionality)

Checklist:

PR should be backported to stable branches
Tested changes locally
Related to issue

Description

When the presence module attempts to clean up records in the presentity table, it replaces the etag with a static, hardcoded string:

 "*#-OFFLINE-#*"

However, the presentity table enforces a uniqueness constraint on the following combination of fields:

MariaDB [kamailio]> show create table presentity;
| presentity | CREATE TABLE `presentity` (
...
  UNIQUE KEY `presentity_idx` (`username`,`domain`,`event`,`etag`),

This approach breaks the uniqueness of etag, which is intended to differentiate records , especially in cases such as parallel calls, or when using kamailio as a forking proxy.

Instead of overwriting the etag with the static offline marker, this patch appends the marker to the existing etag value. This ensures the offline flag is retained while preserving the uniqueness of the etag.

The deletion query was also updated accordingly: it now identifies offline records using a LIKE '%#-OFFLINE-#' clause.

Based on testing, the duplicate key errors no longer occur, and the cleanup logic now behaves as expected. This patch improves the reliability of presentity cleanup without requiring schema or index changes.

Please consider merging into master.

Thanks!

You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/4275

Commit Summary

bc7c17b presence: preserve etag uniqueness when marking presentity for removal

File Changes

(1 file)

M src/modules/presence/presentity.c (90)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.