Content-Length is not mandatory for UDP, the sip message is required to be in a single datagram.
Even that one can check with is_present_hf("Content-Length")
and write a log message from config, I am fine to add an option to log from the module, but I would prefer to be a more generic approach, in order to reuse the same mechanism for similar needs. I would go with a new parameter like log_filter
and then use flags (bits) to control what is logged or not (e.g., bit 1 set, the log missing content length).
As an common recommendation, parameter names should be kept short, ideally one-two words, not to have a very long snake-case name. The name should be suggestive (related to its purpose), but not_the_full_description_of_the_parameter
.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.