[sr-dev] Re: [kamailio/kamailio] Add timer to ping rtpengine (PR #4016)

@xkaraman commented on this pull request. return 1; } if(force == 0) { + /* If ping_interval is set, the timer will ping and test + the rtps. No need to do something during routing */ + if(rtpengine_ping_interval > 0) + return 1; I think you are right, since this function has a bit different semantics that `rtpp_test_ping()`. This function should return whether the node `isdisabled` or not (not if it's reachable since other checks are in play, like pings or already enabled). I have made some modification to the check of `ping_interval` and now we return whatever status we already were if ping timer is enabled. Does this make more sense? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4016#discussion_r1838026033 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4016/review/2429474074(a)github.com>