[sr-dev] git:master:287d1824: ims_ipsec_pcscf: fixed possible use of uninitialized value in ipsec_forward()

Module: kamailio Branch: master Commit: 287d182453e2818c17d439ff68ddd363a86ef578 URL: https://github.com/kamailio/kamailio/commit/287d182453e2818c17d439ff68ddd36… Author: Aleksandar Yosifov <alexyosifov(a)gmail.com> Committer: Aleksandar Yosifov <alexyosifov(a)gmail.com> Date: 2019-06-13T13:22:58+03:00 ims_ipsec_pcscf: fixed possible use of uninitialized value in ipsec_forward() - related to calling "*ul.unlock_udomain" --- Modified: src/modules/ims_ipsec_pcscf/cmd.c --- Diff: https://github.com/kamailio/kamailio/commit/287d182453e2818c17d439ff68ddd36… Patch: https://github.com/kamailio/kamailio/commit/287d182453e2818c17d439ff68ddd36… --- diff --git a/src/modules/ims_ipsec_pcscf/cmd.c b/src/modules/ims_ipsec_pcscf/cmd.c index 576bf56ded..f696ac9e71 100644 --- a/src/modules/ims_ipsec_pcscf/cmd.c +++ b/src/modules/ims_ipsec_pcscf/cmd.c @@ -571,7 +571,7 @@ int ipsec_forward(struct sip_msg* m, udomain_t* d) struct cell *t = tmb.t_gett(); if (!t) { LM_ERR("Error getting transaction\n"); - goto cleanup; + return ret; } req = t->uas.request; @@ -662,7 +662,7 @@ int ipsec_forward(struct sip_msg* m, udomain_t* d) struct socket_info * client_sock = grep_sock_info(via_host.af == AF_INET ? &ipsec_listen_addr : &ipsec_listen_addr6, src_port, dst_proto); if(!client_sock) { LM_ERR("Error calling grep_sock_info() for ipsec client port\n"); - return -1; + goto cleanup; } m->force_send_socket = client_sock;