Re: [sr-dev] git:master: modules_k/nathelper: Add is_rfc1918(ip_addr) function to test ip_addr for rfc1918addresses.

On 7/29/11 4:00 PM, Alex Hermann wrote:

On Friday 29 July 2011, Daniel-Constantin Mierla wrote:

...

I wonder if does not make more sense to have this function in the new ipops module:

http://kamailio.org/docs/modules/devel/modules/ipops.html

It could fit there, although it is used for NAT detection and the nathelper module already has the necessary infrastructure to check for those addresses. I don't like duplicating those in another module.

Indeed there is kind of "conflict of interests" here. Maybe the ipops can get a slightly different implementation, where the match can be, based on parameters, restricted to a network address match. I thought would be useful in non-nat-travesal cases, where nathelper is not loaded.

Cheers, Daniel