Pre-Submission Checklist

• Commit message has the format required by CONTRIBUTING guide
• Commits are split per component (core, individual modules, libs, utils, ...)
• Each component has a single commit (if not, squash them into one commit)
• No commits to README files for modules (changes must be done to docbook files
  in doc/ subfolder, the README file is autogenerated)

Type Of Change

• Small bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds new functionality)
• Breaking change (fix or feature that would change existing functionality)

Checklist:

• PR should be backported to stable branches
• Tested changes locally
• Related to issue #XXXX (replace XXXX with an open issue number)

Description

some user agents send a=sendonly as a session attribute and is_audio_on_hold() returns false when it should return true.

Changes

• changed sdp_session_cell struct in sdp.h to add sendrecv_mode and is_on_hold
• changed parse_sdp_session in sdp.c to iterate session attributes and call extract_sendrecv_mode for assigment to session
• changed ki_is_audio_on_hold in textops.c to look for session sendrecv_mode if its not set in media

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2813

Commit Summary

• core: parse session sendrecv_mode in sdp
• textops: check session sendrecv_mode in is_audio_on_hold

File Changes

• M src/core/parser/sdp/sdp.c (12)
• M src/core/parser/sdp/sdp.h (2)
• M src/modules/textops/textops.c (7)

Patch Links:

• https://github.com/kamailio/kamailio/pull/2813.patch
• https://github.com/kamailio/kamailio/pull/2813.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.