On 12/23/12 4:29 PM, Olle E. Johansson wrote:
23 dec 2012 kl. 13:35 skrev Juha Heinanen jh@tutpro.com:
Daniel-Constantin Mierla writes:
These changes should not be necessary, because the install renamed the files and updated the content.
Have you tested to see if the install works fine now? I guess it got broken. All the files should stay with the base name as dir name, then the install was made to copy with different name and update the man page content properly.
i have had this in my make script:
# Rename kamcmd sed -i -e 's/NAME=kamcmd/NAME=sip-proxy_ctl/' utils/sercmd/Makefile
i hope it still works like it used to:
# sip-proxy_ctl sip-proxy_ctl 0.2 Copyright 2006 iptelorg GmbH This is free software with ABSOLUTELY NO WARRANTY. For details type `warranty'. sip-proxy_ctl>
if kamcmd cannot anymore renamed by editing utils/sercmd/Makefile like in above, the commits need to be reverted.
Reverted.
Now, it's hard for the many of us new to support out-of-repo scripts, so please be gentle when we break stuff that we have no idea that it exists ;-)
I would not be worried about private scripts, they have to be adapted by the owners as we develop.
But it is important that things stay coherent inside the source tree (e.g., in this case, names for binary/manpage were 'sercmd', but was no problem to install as 'kamcmd', if the name would be 'kamcmd', it should work to install as 'sercmd'). The default flavour is kamailio, but we don't get rid of the flavouring framework.
Renaming files can impact installation scripts, so this kind of process has to be done carefully.
The files that are not installed, can stay with any name.
Cheers, Daniel