Pre-Submission Checklist

Commit message has the format required by CONTRIBUTING guide
Commits are split per component (core, individual modules, libs, utils, ...)
Each component has a single commit (if not, squash them into one commit)
No commits to README files for modules (changes must be done to docbook files
in doc/ subfolder, the README file is autogenerated)

Type Of Change

Small bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would change existing functionality)

Checklist:

PR should be backported to stable branches
Tested changes locally
Related to issue #XXXX (replace XXXX with an open issue number)

Description

In case of Emergency-Registrations the S-CSCF was wrongly setting the expires of the ;sos contacts to em_min_expires if they were above em_max_expires.

Other smaller related fixes:

Fixed also another typo in the config params definition.
Added some code to more easily make sense of which attributes of a struct are set with what.
Added conditions to respect the parameter documentation which indicate that if set to 0, the expires conditions won't be used.

You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/3989

Commit Summary

475e437 ims_registrar_scscf: fixing em_max_expires

File Changes

(3 files)

M src/modules/ims_registrar_scscf/config.c (26)
M src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c (2)
M src/modules/ims_registrar_scscf/save.c (14)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.