[sr-dev] [kamailio/kamailio] Add stop_recording function, and make start/stop_recording functions accept flags (#1253)

<!-- Kamailio Pull Request Template --> <!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception --> #### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description <!-- Describe your changes in detail --> ce5362d adds stop_recording function that is similar to start_recording. This is useful when wanting to stop recording in the middle of the call since it has it's own message and is not attached to the offer/answer/delete message (like the "record-call off" flag in rtpengine_manage function). 45b4d35 enables the use of flags with both start_recording and stop_recording functions. This allows overwriting fields like call-id to start/stop recording for different ongoing calls (for example from a rtimer route). You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1253 -- Commit Summary -- * rtpengine: add stop_recording function * rtpengine: make start_recording and stop_recording accept flags -- File Changes -- M src/modules/rtpengine/doc/rtpengine_admin.xml (37) M src/modules/rtpengine/rtpengine.c (55) M src/modules/rtpengine/rtpengine.h (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1253.patch https://github.com/kamailio/kamailio/pull/1253.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1253