@MikhailKalashnikov commented on this pull request.


In src/modules/sipt/sipt.c:

> @@ -102,10 +115,30 @@ static sipt_header_map_t sipt_header_mapping[] =
 		{{"CHARGE_INDICATOR", 1}, 
 			{NULL, 0}
 		}},
-        {"REDIRECTION_INFO", ISUP_PARM_REDIRECTION_INFO, 
-                {{NULL, 0}}  },
-        {"REDIRECTION_NUMBER", ISUP_PARM_REDIRECTION_NUMBER, 
-            		{{"NATURE_OF_ADDRESS", 1}, 
+	{"REDIRECTION_INFO", ISUP_PARM_DIVERSION_INFORMATION,

This existing "REDIRECTION_INFO" actually gets information from diversion info (ISUP_PARM_DIVERSION_INFORMATION) and not from redirection info header (ISUP_PARM_REDIRECTION_INFO).
So this old name is incorrect. It would be better to rename the old "REDIRECTION_INFO" to "DIVERSION_INFO".
But it will break existing behavior. If someone uses this old "REDIRECTION_INFO" he will get wrong results.
So I did not change existing behavior, only corrected documentation of "REDIRECTION_INFO"


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.