Pre-Submission Checklist

Commit message has the format required by CONTRIBUTING guide
Commits are split per component (core, individual modules, libs, utils, ...)
Each component has a single commit (if not, squash them into one commit)
No commits to README files for modules (changes must be done to docbook files
in doc/ subfolder, the README file is autogenerated)

Type Of Change

Small bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would change existing functionality)

Checklist:

PR should be backported to stable branches
Tested changes locally
Related to issue #3814

Description

When the fixup is done in main using fix_rls function (fixing the route lists in cfg file), all the children inherit the memory allocated as a copy that needs separate management.

The function responsible for the fixup (fix_actions) is also used to call the free_fixup function with an added argument.

Then on main, we call the free_rls ( as fix_rls) on two separate occasions. Once in cleanup() function for the main process and once in the sig_usr() function for each of the children.

This seems to work fine and after debugging with file_out fixups, I can no longer see memory leaks due to the malloced memory in one of the fixups.

main.c: Call free_rls() in cleanup() function to clean route lists and fixed up parameters in main process.
main.c: Call free_rls() in sig_usr() function to clean route lists and fixed up parameters in child processes.

My question is, after a parameter is fixed, is it saved somewhere else, therefore we can immediately free the fix-up resources and not on shutdown?

You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/4023

Commit Summary

c4650cd core: Add fix_actions function parameter in fix_actions to free fixed up resources

File Changes

(5 files)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.