10 Mar
2020
10 Mar
'20
1:58 p.m.
@sobomax - thanks for looking into it.
@mojtabaesfandiari - if there are continuous parts of code copied over from an existing
module such as rtpproxy, you have to keep original copyright line and add yours for the
additions. You can split the file in two, one with copied code and one with your code, if
you want to have them clearly separate.
I haven't compared any files to have an opinion on it, but if there is a copyright
dispute, it should be settled before merging.
@mojtabaesfandiari - as I looked a bit over, I noticed large parts of commented code.
Remove them if they are not useful anymore, makes the files big and hard to follow.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2208#issuecomment-597025761