12 Mar
2013
12 Mar
'13
11 p.m.
On 03/12/13 16:32, Juha Heinanen wrote:
i would have liked to solve this problem by
introducing a new nathelper
var "nat ping this contact bflag" that tells which bflag to check when
deciding if a contact should be nat pinged. that bflag would then be
set before registrar save() is called in addition to setting the "behind
nat" bflag.
Personally I don't really care either way, but my gut feeling tells me
that the nathelper module should ping NAT'd contacts by defaults without
requiring an additional flag. Otherwise it wouldn't be much of a
nathelper module, but more of a kind of generic contact-pinger module.
Plus, requiring an additional flag to be set to get old behaviour back
would break backwards compatibility. Anyway, those were the reasons to
create a flag to explicitly and selectively disable NAT pings instead.
BR