@tsearle commented on this pull request.


In src/modules/rtpengine/rtpengine.c:

> +				else if(str_eq(&key, "from-tags")) {
+					err = "missing value";
+					if(!val.s)
+						goto error;
+
+					if(!ng_flags->from_tags) {
+						ng_flags->from_tags =
+								bencode_list(ng_flags->dict->buffer);
+					}
+					bencode_list_add_str(ng_flags->from_tags, &val);
+				} else

I looked some more about merging the logic.... from-tag is a string in flags, so it doesn't support specifying it multiple times...

also there is som logic for checking that from-tag is set when no sip_msg is present, so I feel more comfortable keeping it as is


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <kamailio/kamailio/pull/4274/review/2912189352@github.com>