Pre-Submission Checklist

Commit message has the format required by CONTRIBUTING guide
Commits are split per component (core, individual modules, libs, utils, ...)
Each component has a single commit (if not, squash them into one commit)
No commits to README files for modules (changes must be done to docbook files
in doc/ subfolder, the README file is autogenerated)

Type Of Change

Small bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would change existing functionality)

Checklist:

PR should be backported to stable branches
Tested changes locally
Related to issue #XXXX (replace XXXX with an open issue number)

Description

This PR adds support for $hfl(Diversion)[] and $hflc(Diversion).

This parse_diversion.c was inspired by parse_pai_ppi.c. I am not sure if it's breaking the existing implementation and usage. I believe it does not.

During some experimentation with the hfl(name)[-1], I encountered weird behavior with negative indexing for the already supported headers like Via, Route, and Contact. -1 yields null and -2 yields the last one and so on. Separate PR can be introduced if necessary.

Any feedback is welcome.

You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/3650

Commit Summary

9d60e79 parser: Extend diversion for multiple bodies
cd2efcf pv: Add hfl and hflc support for Diversion header

File Changes

(3 files)

M src/core/parser/parse_diversion.c (149)
M src/core/parser/parse_diversion.h (10)
M src/modules/pv/pv_core.c (175)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.