[sr-dev] git:5.7:c5ed0e65: tls: historical code comment on repeating SSL_CTX per worker

Module: kamailio Branch: 5.7 Commit: c5ed0e65b2530443b1367986dac2b3da111c0701 URL: https://github.com/kamailio/kamailio/commit/c5ed0e65b2530443b1367986dac2b3d… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-01-11T08:04:58+08:00 tls: historical code comment on repeating SSL_CTX per worker (cherry-pick from 29007ada5bc9e07ede3cdbce285f04d1298c0612) --- Modified: src/modules/tls/tls_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/c5ed0e65b2530443b1367986dac2b3d… Patch: https://github.com/kamailio/kamailio/commit/c5ed0e65b2530443b1367986dac2b3d… --- diff --git a/src/modules/tls/tls_mod.c b/src/modules/tls/tls_mod.c index 7cad1b046e4..beaf1b7b70b 100644 --- a/src/modules/tls/tls_mod.c +++ b/src/modules/tls/tls_mod.c @@ -433,6 +433,16 @@ static int tls_engine_init(); int tls_fix_engine_keys(tls_domains_cfg_t *, tls_domain_t *, tls_domain_t *); #endif +/* + * OpenSSL 1.1.1+: SSL_CTX is repeated in each worker + * + * OpenSSL RSA blinding works in single-process multi-threaded mode + * and depends on pthread_self() to separate threads. In Kamailio multi-process workers + * pthread_self() will not necessarily be unique, this will result in incorrect BN + * operations���hence we create a separate SSL_CTX for each worker + * + * EC operations do not use pthread_self(), so could use shared SSL_CTX + */ static int mod_child(int rank) { if(tls_disable || (tls_domains_cfg == 0))