• Access to the d_table entries should be done by reference so there is
  no risk of race conditions to get and release the lock

Pre-Submission Checklist

• Commit message has the format required by CONTRIBUTING guide
• Commits are split per component (core, individual modules, libs, utils, ...)
• Each component has a single commit (if not, squash them into one commit)
• No commits to README files for modules (changes must be done to docbook files
  in doc/ subfolder, the README file is autogenerated)

Type Of Change

• [ x ] Small bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds new functionality)
• Breaking change (fix or feature that would change existing functionality)

Checklist:

• PR should be backported to stable branches
• Tested changes locally
• Related to issue #2547

Description

It was seen the access to the d_table was not being made by reference on the function dmq_send_all_dlgs. It was then leading to race conditions where the same entry could have its lock changed elsewhere and then a dead lock would occur. By checking the code in other places where the d_table is used, everywhere it is accessed by reference, this function was the only one not following this logic.
Changes were done to have "entry" as a reference to d_table and not a copy.

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2570

Commit Summary

• dialog/dmq access dialog table by reference

File Changes

• M src/modules/dialog/dlg_dmq.c (10)

Patch Links:

• https://github.com/kamailio/kamailio/pull/2570.patch
• https://github.com/kamailio/kamailio/pull/2570.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.