4 Oct
2013
4 Oct
'13
4:32 p.m.
Hi Henning,
The only small thing I noticed is that you changed the indention in the
variable definition in pv_set_mcd_expire from tabs to
space
Unintentional, sorry, not sure how that happened :/
just commit the patch, looks good for me.
Thanks, will do.
Best,
Charles
On 4 October 2013 13:43, Henning Westerholt <henning.westerholt(a)1und1.de>wrote;wrote:
Am Freitag, 4. Oktober 2013, 12:16:32 schrieb Charles
Chance:
--
*Charles Chance*
Managing Director
t. 0121 285 4400 m. 07932 063 891
--
www.sipcentric.com
Follow us on twitter @sipcentric <http://twitter.com/sipcentric>
Sipcentric Ltd. Company registered in England & Wales no. 7365592. Registered
office: Unit 10 iBIC, Birmingham Science Park, Holt Court South, Birmingham
B7 4EJ.
Sorry hit reply only, first time.
Would you like me still to update to use mcd_free or leave it with you?
Hi Charles,
just commit the patch, looks good for me. The only small thing I noticed is
that you changed the indention in the variable definition in
pv_set_mcd_expire
from tabs to space, would be great if you could adapt this.
With regards to the other wrapper (mcd_free) that Daniel mentioned, this is
only used as callback function for the library. I'll clarify this in the
comments that this is the purpose of this code.
Regards,
Henning Westerholt