Pre-Submission Checklist

[ /] Commit message has the format required by CONTRIBUTING guide
[ /] Commits are split per component (core, individual modules, libs, utils, ...)
[ /] Each component has a single commit (if not, squash them into one commit)
[ /] No commits to README files for modules (changes must be done to docbook files
in doc/ subfolder, the README file is autogenerated)

Type Of Change

Small bug fix (non-breaking change which fixes an issue)
[/ ] New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would change existing functionality)

Checklist:

PR should be backported to stable branches
[ /] Tested changes locally
Related to issue #XXXX (replace XXXX with an open issue number)

Description

A couple of commits into db_redis and ndb_redis adding TLS support and also password support to db_redis.

This mainly includes checking if proper parameter is provided (for ndb_redis is tls option in the DB URL and, for db_redis, a new opt_tls parameter) and creates a temporary SSL context that is used to initialise the redis context.

Also added ca_path parameter to both modules to be able to define a valid folder containing the root certificates used to validate TLS' certificate chain.

db_redis is also updated with a db_pass parameter to provide a DB access password.

TLS support is automatically enabled by checking libhiredis_ssl.so existence in each Makefile and defining a WITH_SSL flag that enables all the corresponding code lines.

You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/3477

Commit Summary

db1c546 db_redis: Adding TLS support
d3b4356 ndb_redis: Adding TLS support

File Changes

(12 files)

M src/modules/db_redis/Makefile (24)
M src/modules/db_redis/db_redis_mod.c (13)
M src/modules/db_redis/doc/db_redis.xml (5)
M src/modules/db_redis/doc/db_redis_admin.xml (59)
M src/modules/db_redis/redis_connection.c (98)
M src/modules/db_redis/redis_connection.h (6)
M src/modules/ndb_redis/Makefile (15)
M src/modules/ndb_redis/doc/ndb_redis.xml (5)
M src/modules/ndb_redis/doc/ndb_redis_admin.xml (26)
M src/modules/ndb_redis/ndb_redis_mod.c (10)
M src/modules/ndb_redis/redis_client.c (69)
M src/modules/ndb_redis/redis_client.h (7)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.