The default value for `tls_method` is `TLSv1`: https://kamailio.org/docs/modules/devel/modules/tls.html#tls.p.tls_method . This value is suboptimal as default.
Please change the default value to `TLSv1.2+` and remove `modparam("tls", "tls_method", …)` from misc/examples/outbound/edge_websocket.cfg and misc/examples/webrtc/websocket.cfg .
Yes, it make sense to change the default to not allow obselete/deprecate algorithms. Regarding the change in the examples, I think this can stay, it does not hurt and they are used from people also with older versions in the end.
Usually the default value is set to what's expected to be commonly available, as Kamailio can still be used on old distros such as centos 6/7, debian 9. Using ifdefs in the code based on availability of tls version will make it hard to present in documentation what would be default value. The reason of modparam is to offer the flexibility to set desired value and not depend on developer's default value.
I am not against on changing it, just to be in a way that does not result in compile failures for not-very-old distros and the documentation to be able to reflect easily the default value.
Regarding misc examples, many are very old, not really maintained, probably kamailio will not start with several of them. They are kept more as documentation/reference. But people are more that welcome to test and update them.
Overall, just made pull requests for the changes you think worth to be done.
Closed #3301 as completed.
-
Daniel-Constantin Mierla -
Henning Westerholt
-
Дилян Палаузов