This adds the 'domain' column to the testdb_udomain db connection test in the usrloc module. When using Cassandra 2 as the database module (a module I'm working on that I will be submitting a PR for once it's stable) doing a query by only username can cause issues if you create your Cassandra partition key as username and domain.
This shouldn't affect the query functionality in general as it's only doing a query to test the connection to the database. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/161
-- Commit Summary --
* Add domain to connection test query so it works with Cassandra
-- File Changes --
M modules/usrloc/udomain.c (21)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/161.patch https://github.com/kamailio/kamailio/pull/161.diff
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/161
Thanks, I think it should be integrated but with the condition on domain based on **use_domain** parameter, I guess you have that set for your testing, right?
A second patch can be added to the pull request.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/161#issuecomment-101747277
Ah yes, good point. I do have that set right now. I'll get that updated.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/161#issuecomment-101794965
Closed #161.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/161#event-309920886
Reworked the patch because the old versions of C don't allow declarations of arrays with size specified as variable. It is now in master branch.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/161#issuecomment-104011678
-
Daniel-Constantin Mierla -
Erik Davidson