Hello,
I have been searching for the error in KAMCTL regarding lcr commands in the new RC1 version.
The files "kamctl.base" and "kamctl" in the directory "utils/kamctl" should be corrected, because following error is included by now:
=========== KAMCTL.BASE ===========
1) wrong table names in kamctl.base 2) wrong column definition (grp_id is no longer present)
excerpt: [...] # lcr tables if [ -z "$LCR_TABLE" ] ; then LCR_TABLE=lcr fi LCR_ID_COLUMN=lcr_id LCR_PREFIX_COLUMN=prefix LCR_GRPID_COLUMN=grp_id
# gw table if [ -z "$GW_TABLE" ] ; then GW_TABLE=gw fi [...]
======= KAMCTL =======
1) the DB-queries are not up to date, because the table structure has changed; now three tables instead of two are used; the GRPID_column is no longer valid a.s.o.
2) I have not found any declaration of RPCCMD within the sourcecode - so these functions are not supported now
excerpt:
[...] ### LCR management # lcr() { case $1 in show_gws) require_dbengine mecho "lcr gateways" QUERY="select * FROM $GW_TABLE ORDER BY $LCR_ID_COLUMN, $LCR_GW_GRPID_COLUMN; " $DBROCMD "$QUERY" ;; show_routes) require_dbengine mecho "lcr routes" QUERY="select * FROM $LCR_TABLE ORDER BY $LCR_ID_COLUMN, $LCR_PREFIX_COLUMN; " $DBROCMD "$QUERY" ;; reload) $RPCCMD lcr.reload ;; dump_gws) $RPCCMD lcr.dump_gws ;; dump_routes) $RPCCMD lcr.dump_lcrs ;; [...]
regards,
Klaus Feichtinger
Klaus Feichtinger writes:
I have been searching for the error in KAMCTL regarding lcr commands in the new RC1 version.
The files "kamctl.base" and "kamctl" in the directory "utils/kamctl" should be corrected, because following error is included by now:
better to remove lcr db commands from kamctl, since there is to many fields and they don't scale.
i'm not using kamctl myself at all and cannot commit supporting lcr related kamctl commands.
-- juha
On 10/6/10 10:04 AM, Juha Heinanen wrote:
Klaus Feichtinger writes:
I have been searching for the error in KAMCTL regarding lcr commands in the new RC1 version.
The files "kamctl.base" and "kamctl" in the directory "utils/kamctl" should be corrected, because following error is included by now:
better to remove lcr db commands from kamctl, since there is to many fields and they don't scale.
i'm not using kamctl myself at all and cannot commit supporting lcr related kamctl commands.
I suggest removing (or at least disabling them) for 3.1 and re-introduce when someone codes it. Since is a side tool, it is not problem to get it in 3.1.1 or so.
Cheers, Daniel