<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
Fix coverity found issue. Unlikely to happen but still it was a bug leading to potential crashes.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1931
-- Commit Summary --
* siptrace: fix coverity found issue
-- File Changes --
M src/modules/siptrace/siptrace.c (6)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1931.patch https://github.com/kamailio/kamailio/pull/1931.diff
The commit message should explain what is fixed, not what tool reported the issue. So it should be something like:
``` siptrace: safety check for tm callback parameter ```
Also, the comments should not be related to discovery tool -- better do not add comments that are not relevant for understanding the code.
Fixed. Sorry for not complying to the rules. Won't happen again
We try to be consistent and coherent with the commit messages, that's why we point them in pull request and try to have most of them relevant for the history of development.
But if it happens again, no big worries, the message in the commit of the pull request can be changed easier than after commit is merged in master.
I am going to merge it, thanks!
Merged #1931 into master.